Skip to content

Add trustAllCerts flag #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

Add trustAllCerts flag #12

merged 4 commits into from
May 15, 2025

Conversation

nice77
Copy link
Contributor

@nice77 nice77 commented May 6, 2025

No description provided.

@Piasy
Copy link
Member

Piasy commented May 7, 2025

Hi @nice77 , thank you for your contribution!

Could you add some unit test cases to verify that trustAllCerts could work as expected? e.g. make it work with local self signed certs.

@nice77
Copy link
Contributor Author

nice77 commented May 13, 2025

Hi, @Piasy!

I've added tests to check if trustAllCerts flag works as expected. Can you please take a look?

@nice77
Copy link
Contributor Author

nice77 commented May 14, 2025

Hi, @Piasy! Haven't heard from you in a while - can you please take a look?

@Piasy
Copy link
Member

Piasy commented May 15, 2025

Hi @nice77 , sorry for the delay. JS test failed, but I'll merge it and fix it.

@Piasy Piasy merged commit 375b829 into HackWebRTC:main May 15, 2025
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2025
* Add way to create an unsafe client

* Add way to create an unsafe client

* Add tests

---------

Co-authored-by: Minnullin Niyaz <[email protected]> 375b829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants